Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing initial status issue #261

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Jan 5, 2022

Fixes # .

Summary/Motivation:

If the uptime/downtime provided is fractional, Egret may not enforce the initial on/off time correctly. The new tiny_uc_12.json demonstrates the issue:

min_up_time: 2.2
initial_status: 1

Currently, the formulation allows a decommitment in the 2nd hour using an hourly horizon, e.g, [1,0,...] is an acceptable schedule. The bug fix and new test ensure this isn't permitted.

Changes proposed in this PR:

  • Change inappropriate round to math.ceil for InitialTimePeriodsOffLine and InitialTimePeriodsOnLine.
  • When a ModelData object is serialized, create the directory the user specifies if it doesn't exist.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven changed the title Creating directory if it doesn't exist Fixing initial status issue Jan 5, 2022
@bknueven bknueven enabled auto-merge January 5, 2022 22:43
@bknueven bknueven merged commit d0a323d into grid-parity-exchange:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants