Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
If the uptime/downtime provided is fractional, Egret may not enforce the initial on/off time correctly. The new
tiny_uc_12.json
demonstrates the issue:Currently, the formulation allows a decommitment in the 2nd hour using an hourly horizon, e.g,
[1,0,...]
is an acceptable schedule. The bug fix and new test ensure this isn't permitted.Changes proposed in this PR:
round
tomath.ceil
forInitialTimePeriodsOffLine
andInitialTimePeriodsOnLine
.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: