Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] support cuGetProcAddress and cuGetProcAddress_v2 #13

Closed
wants to merge 0 commits into from

Conversation

pokerfaceSad
Copy link
Contributor

  • hook cuGetProcAddress_v2
  • cuGetProcAddress and _v2 serve as lib entry point

@pokerfaceSad
Copy link
Contributor Author

@grgalex
PTL, fix #11

@grgalex
Copy link
Owner

grgalex commented Dec 7, 2023

Thanks for the PR!

Some minor comments:

  1. It makes sense to split into 2 commits, the first only touching the existing cuGetProcAddress, where we add the initialize_libvnshare() call. The 2nd commit will add support for cuGetProcAddress_v2.
  2. We want concise commit titles, which start with the subsystem that the commit touches. In this case:
    1. hook: Add conditional library initialization in cuGetProcAddress()
    2. hook: Add hook for cuGetProcAddress_v2() to support CUDA >=12
  3. We also want descriptive commit messages, which first give some background and finally describe the actions taken to tackle the issue. In this case, you can take a look at your own comment [1] for inspiration :)
  4. Use the same email address as your GH account when committing. If you want to use a different address, you can add it to your GH account via the settings.
  5. Sign your commits (git commit -sm), so they have a Signed-off-by: line at the end. Use your name and email address. Look at the existing commits for a reference.
  6. Add a line with Closes #11 at the end of the commit message with one line empty before and one after, before the Signed-off-by: line. This will automatically close issue Pytorch 2.1 GPU access not seen / managed by nvshare #11 once we merge.

Can you apply these changes and re-push? If you need any help, feel free to ask for it!

[1] #11 (comment)

@pokerfaceSad
Copy link
Contributor Author

@grgalex submit another PR in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants