tree wide: use simple 16 byte random string for UUID #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all we are using UUIDs for is to avoid duplicate names then we can achieve the same thing by using a random 16 byte string rather than strictly adhering to the UUID v4 spec (which just sets a couple of the bytes to a known value for identification purposes). This way we can reduce dependencies by just relying on the bare minimum of `getrandom`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieves the same purpose and allows us to reduce dependencies by just relying on the bare minimum of
getrandominstead of the whole uuid crate.This supercedes #531 which was waiting for uuid-rs/uuid#475