Update default memory format #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on conversation in greshake#1930
MaxVerevkin
approved these changes
Aug 13, 2023
bim9262
commented
Aug 14, 2023
| @@ -86,7 +86,7 @@ pub async fn run(config: &Config, api: &CommonApi) -> Result<()> { | |||
| .await?; | |||
|
|
|||
| let mut format = config.format.with_default( | |||
| " $icon $mem_avail.eng(prefix:M)/$mem_total.eng(prefix:M)($mem_total_used_percents.eng(w:2)) ", | |||
| " $icon $mem_used.eng(prefix:Mi)/$mem_total.eng(prefix:Mi)($mem_used_percents.eng(w:2)) ", | |||
There was a problem hiding this comment.
Just wanted to double check, do you think using the mem_ued and base 2 units is the way to go?
I tried to do some research about what is used (base 2 or 10) and I believe RAM and disk size are usually reported with base 2 units while network speed is measured in base 10 units.
There was a problem hiding this comment.
Probably. At least, htop does so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation in #1930