Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[tests] Update xUnit packages to the latest 2.4.0 versions (dotnet#1974)
(From the "cross your fingers and hope this works" department...) Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/3574/ A Jenkins build is UNSTABLE when any unit tests fail. In the case of [PR Build dotnet#3574][0], there were no reported test failures, so what went wrong? Further investigation showed that an on-device unit test was crashing: /Users/builder/android-toolchain/sdk/platform-tools/adb -s emulator-5570 shell am instrument -w "Xamarin.Android.Bcl_Tests/xamarin.android.bcltests.NUnitInstrumentation" INSTRUMENTATION_RESULT: shortMsg=Process crashed. The unit test was in turn crashing because of an unhandled exception: E/mono ( 4120): Unhandled Exception: (TaskId:115) E/mono ( 4120): System.IO.IOException: Unable to read data from the transport connection: Connection reset by peer. ---> System.Net.Sockets.SocketException: Connection reset by peer (TaskId:115) E/mono ( 4120): at System.Net.Sockets.Socket.Receive (System.Byte[] buffer, System.Int32 offset, System.Int32 size, System.Net.Sockets.SocketFlags socketFlags) [0x00017] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/Socket.cs:1773 (TaskId:115) E/mono ( 4120): at System.Net.Sockets.NetworkStream.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 size) [0x0009b] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/NetworkStream.cs:513 (TaskId:115) E/mono ( 4120): --- End of inner exception stack trace --- (TaskId:115) E/mono ( 4120): at System.Net.Sockets.NetworkStream.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 size) [0x000c3] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/NetworkStream.cs:525 (TaskId:115) ... E/mono ( 4120): at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00000] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:1213 (TaskId:115) ... I/Zygote ( 1145): Process 4120 exited cleanly (255) (TaskId:115) This is not a "normally catchable" exception -- it's happening on the ThreadPool -- so our current hypothesis/prayer is that updating xUnit to a newer version will "magically fix things" by xUnit having code to prevent unhandled exceptions from the ThreadPool. Even if that doesn't work, we should be using a newer xUnit anyway, so no harm in bumping. [0]: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/3574/
- Loading branch information