Don't redirect stdin when running headless #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streams that were being passed are never used.
robinheghan
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #341
It changes the "quiet" flag to "headless" for a better description of what's now happening. Previously
gren runbypassed stdout redirection for the compile step, now it's also bypassing stdin redirection. This prevents hijacking the stdin of the program being run.In a separate commit, it also simplifies the
RedirectTerminalIOmessage.Note: there's a larger-scale fix that could be made here by handling stdin redirection separately, tracking the target on the model. I went with this smaller-scale fix for now.