Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: dot repeatable #6

Closed
1 task done
kevintraver opened this issue Jun 19, 2024 · 2 comments
Closed
1 task done

feature request: dot repeatable #6

kevintraver opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kevintraver
Copy link

Did you check the docs?

  • I have read all the docs

Is your feature request related to a problem? Please describe.

Current commands are not dot repeatable

Describe the solution you'd like

Current commands to be dot repeatable

Describe alternatives you've considered

n/a

Additional context

No response

@kevintraver kevintraver added the enhancement New feature or request label Jun 19, 2024
@gregorias
Copy link
Owner

Thanks, will work on fixing this as soon as I get the time.

@gregorias gregorias self-assigned this Jun 19, 2024
@gregorias
Copy link
Owner

Note to self: I found out why dot-repeatability is not present. In

M.operator = function(mode, movement)
local mmode = require("coerce.coroutine").cb_to_co(M.operator_cb)(mode, movement)
local selected_region = M.get_selected_region(mmode)
return selected_region
, I wrote a nice helper function that turns operator mechanics into a coroutine, which lets me use a more readable sequential style. The unfortunate side-effect is that the operatorfunc callback only contains some coroutine utility function. I’ll probably will need to rewrite the code to contain the entire coercion code in that callback.

gregorias added a commit that referenced this issue Jun 22, 2024
The interplay with dot-repeatability was discovered in #6.
gregorias added a commit that referenced this issue Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants