vim.lsp.buf.rename returns nil on successful rename

[tdcdev]

Hi @gregorias,

Thanks for this nice plugin!

I have an issue with the LSP rename function. I am using nvim 0.10 and pyright LSP server.

When I try to force a word it seems that the LSP rename is not called and only the local transformer is triggered. After some digging, it appears that the LSP rename is called but is overridden by the local transformer.

I think the problem comes from here as the vim.lsp.buf.rename returns nothing if the rename is done without errors.

Regards,

[gregorias]

Hi Thomas,

Thanks for reporting.

The default lsp rename is transform_lsp_rename_with_failover. It’s intended behavior that if the rename fails, we just apply a local transformation. It would only be a bug if LSP rename was working, but Coerce somehow didn’t recognize or use that.

If you’d like to have different behavior:

1. You can relatively easily configure your own modes (instructions, default modes).
2. You can make a case that this plugin should use different defaults.

[tdcdev]

It would only be a bug if LSP rename was working, but Coerce somehow didn’t recognize or use that.

I think this is exactly what happens. Because transform_lsp_rename returns the result of vim.lsp.buf.rename which is nil if the rename succeed.

EDIT:

Actually it seems vim.lsp.buf.rename returns nothing.

[gregorias]

I'm busy at the moment, so I'll speculate and double check later. Especially the rename not returning anything. That's weird. Anyway, I believe there's a unit test for LSP rename. If what you are saying is correct, then LSP rename would never work. You could consider double checking on your side of LSP rename works on your end, but doesn't work with Coerce.

…

On Tue, May 28, 2024, 09:05 Thomas Da Costa ***@***.***> wrote: It would only be a bug if LSP rename was working, but Coerce somehow didn’t recognize or use that. I think this is exactly what happens. Because transform_lsp_rename <https://github.com/gregorias/coerce.nvim/blob/fdbc61acc81da3c7179e27d4122d5d794aeae2e5/lua/coerce/transformer.lua#L51> returns the result of vim.lsp.buf.rename which is nil if the rename succeed. — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFQLUOPUDYQWTGEHAJDRYTZEQUCZAVCNFSM6AAAAABILAKLQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGQ4DSMBWGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>