Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git repository checkouts using git worktree #1

Merged
merged 5 commits into from
Sep 25, 2022

Conversation

cgrindel
Copy link
Collaborator

@cgrindel cgrindel commented Sep 25, 2022

Related to aspect-build/silo#353

When working with repository code using git worktree, the worktree's .git is a file that references the location of the worktree's git files. This location (i.e., directory) only contains pertinent data for that worktree. In addition, it has a file called commondir that specifies the location of the rest of the repository files.

This PR updates git-descrive-semver to identify whether the current worktree uses the commondir mechanism. If so, it enables support for this mechanism in go-git.

@cgrindel cgrindel self-assigned this Sep 25, 2022
Copy link
Owner

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gregmagolan gregmagolan merged commit 1ca49fc into main Sep 25, 2022
@cgrindel cgrindel deleted the support_common_dir branch September 26, 2022 13:22
cgrindel added a commit that referenced this pull request Sep 26, 2022
* Started adding tests

* Finish tests for FindGitDir

* Refactor setup code

* Add tests for shouldEnableCommondDir

* Remove commented code
cgrindel added a commit that referenced this pull request Sep 26, 2022
* Started adding tests

* Finish tests for FindGitDir

* Refactor setup code

* Add tests for shouldEnableCommondDir

* Remove commented code
gregmagolan pushed a commit that referenced this pull request Nov 20, 2022
* Started adding tests

* Finish tests for FindGitDir

* Refactor setup code

* Add tests for shouldEnableCommondDir

* Remove commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants