Allow additional identifiers to be passed in to the babel plugin #966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I would like to wrap
loadable
in my own higher order component functions. Loadable by default only injects a webpack chunk name forloadable
andlazy
, but can readily accept additional identifiers.This PR allows us to rewrite
to
We actually have a separate HOC for modals, so we would not be able to simply rename LoadablePageHOC to loadable for the sake of the existing babel plugin. With the changes, we can specify
additionalIdentifiers: [ 'LoadablePageHOC', 'LoadableModalHOC']
to transform both.Test plan
New tests have been added that showcase the custom identifier being transformed or not, depending on babel options.