-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats option to webpack plugin #778
Conversation
Hey, I've read the related conversation to this PR and saw (#770 (comment)) you say perhaps this was overkill and that #779 would suffice. Personally, I re-use the assets json file for a few other bits and bobs and so the most recent update to loadable-components broke my setup. I've had to patch the code to add in an extra stats option (namely |
Good point. While we're waiting for a maintainer's opinion on this, feel free to use "@loadable/webpack-plugin": "depoulo/loadable-components#@loadable/webpack-plugin/stats-opts-770/5.16.0", in your package.json in the meantime (still better than patching the code). |
Actually I always thought about splitting plugin into two parts - Webpack and stats. you should not use plugin output for anything except loadable itself, please try to learn from this incident... that automatically “grants” you ability to use any plugin you want and decouples loadable server from Webpack integration. |
* feat: code splitting and lazy loading with loadable-components * chore: use alternative webpack loadable plugin to fix generated stats Check gregberge/loadable-components#778 * refactor: improve ssr renderer abstractions * chore: clean production build
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary
Fix #770 as per my suggestion.
Test plan
stats
options. The generated stats JSON file matches those options.