Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-6407 Spreadsheet block: indicators are not present #164

Open
planet-4 opened this issue Sep 30, 2021 · 11 comments
Open

PLANET-6407 Spreadsheet block: indicators are not present #164

planet-4 opened this issue Sep 30, 2021 · 11 comments
Assignees
Labels

Comments

@planet-4
Copy link

planet-4 commented Sep 30, 2021

Example Page

When a user wants to sort the order of the content appearing in a spreadsheet there are no indicators appearing to inform the user this is even possible.

There is also no reset option to return the table to the default view.

Screenshots

Screenshot
Screenshot

Reporter: ktolen
Sections: Block: Spreadsheet

Potentially affected repositories: planet4-plugin-gutenberg-blocks

JIRA ticket: https://jira.greenpeace.org/browse/PLANET-6407

@VallariAg
Copy link

I would like to work on this issue.

@GP-Dan-Tovbein
Copy link

@VallariAg Go for it!

@GP-Dan-Tovbein
Copy link

@VallariAg FYI, here is the ticket url for a more information

@comzeradd
Copy link
Member

Hi @VallariAg 👋 Are you working on this? Do you require any assistance from the team?

@VallariAg
Copy link

VallariAg commented Oct 22, 2021

Sorry, I'll work on this and will ask for help when I get stuck. Sorry for the delay!

@artze
Copy link

artze commented Feb 1, 2022

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

@suzi-greenpeace
Copy link
Contributor

suzi-greenpeace commented Feb 1, 2022 via email

@VallariAg
Copy link

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

Yes, sorry, I haven't been able to work on it. Go ahead :)

@artze
Copy link

artze commented Feb 1, 2022

Alright, I will take this up :)

@comzeradd comzeradd assigned artze and unassigned VallariAg Feb 2, 2022
@artze
Copy link

artze commented Feb 5, 2022

@comzeradd

Hi, I got a question.

At first render when the table is not sorted (like below), is there a preference on what kind of icon we should display next to the column titles?
image

I'm thinking something like the following:
image

+++

I'd also like to keep the new icon consistent with the existing asc / desc ArrowIcon. Would like to know your thoughts on the best way to achieve this, e.g.:

  • Draw a new icon that looks similar to the current one and use its svg
  • Use an icon pack (which might involve changing the existing icons)
  • etc.

@comzeradd
Copy link
Member

@magalifatome do we have a preference on how this icon should look?
For reference, check the example page and sort by a column to see the sort icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants