PLANET-7744 Fix Media & Text padding in large screens #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-neptune
that referenced
this pull request
Feb 7, 2025
/unhold 411d5ad9-78d0-4fde-a5b1-2fb9846dd84b
Test instance is ready 🚀🌑 neptune | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.02.12 10:15:37 |
mleray
force-pushed
the
fix-media-text-padding
branch
from
bbf6cad to
e68349c
Compare
planet-4
added a commit
to greenpeace/planet4-test-neptune
that referenced
this pull request
Feb 7, 2025
/unhold 64f21931-2aa9-49a7-a3a5-619e25ec0986
mleray
force-pushed
the
fix-media-text-padding
branch
from
e68349c to
ce7aae9
Compare
planet-4
added a commit
to greenpeace/planet4-test-neptune
that referenced
this pull request
Feb 7, 2025
/unhold f9b874d4-76f5-4fb2-84c1-1653a4b793c8
mleray
requested review from
a team,
sagarsdeshmukh and
GP-Dan-Tovbein
and removed request for
a team
mleray
added
UAT Passed
Otherwise the content is impossible to read
mleray
force-pushed
the
fix-media-text-padding
branch
from
ce7aae9 to
acf8adb
Compare
planet-4
added a commit
to greenpeace/planet4-test-neptune
that referenced
this pull request
Feb 12, 2025
/unhold b1fb11dd-28b2-4183-a5e3-a65946d07fa8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7744
Otherwise the content is impossible to read. I also made some design changes following Houssam's recommendations.
Testing
Make sure to check all screen sizes in the following pages:
Please also make sure that the Page Header pattern still look fine, for example on this page