Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-6530 Add new Secondary Navigation Block #2494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Osong-Michael
Copy link
Contributor

@Osong-Michael Osong-Michael commented Jan 8, 2025

Summary


Ref: https://jira.greenpeace.org/browse/PLANET-6530

Testing

  1. Create a new Page with a few headings(H2 only) and paragraphs
  2. It is good to add a page header at the beginning of the page, for best UI this blocks needs the Page Header Pattern
  3. Just after the Page Header, add the secondary navigation block.(Make sure Beta Blocks feature is enabled in Planet 4 settings). View on Frontend. In the frontend, the Secondary Navigation block should be sticky just below the main Navbar on scroll.

@Osong-Michael Osong-Michael self-assigned this Jan 8, 2025
@Osong-Michael Osong-Michael marked this pull request as draft January 8, 2025 12:55
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Jan 8, 2025
/unhold 8ca50501-4da0-49f2-bfc3-d4a03dd05c25
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Jan 10, 2025
/unhold af120a1d-087e-463c-9263-192fcafa8ecf
@planet-4
Copy link
Contributor

planet-4 commented Jan 10, 2025

Test instance is ready 🚀

🌑 phobos | admin | blocks report | CircleCI | composer-local.json

⌚ 2025.02.10 15:57:00

planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 5, 2025
/unhold 60d68366-8430-4197-a756-e0d63a61c52a
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 5, 2025
/unhold e279ab49-efeb-45de-a6b9-cc809b0cf9cf
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 10, 2025
/unhold 51304a82-de88-4eee-bc91-7b1793164290
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 10, 2025
/unhold 7c318aba-4e2f-49b9-884f-d62eac53f9bc
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 10, 2025
/unhold 77d496b2-2627-4cc0-a7f6-5b80e020a04f
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 10, 2025
/unhold 05358eb0-a584-48a5-a934-6d11882ae415
- Added all necessary files for the new block
- Added tests for the new block
planet-4 added a commit to greenpeace/planet4-test-phobos that referenced this pull request Feb 10, 2025
/unhold 9aa5392b-3132-40d4-8cb9-91de61b2bda4
@Osong-Michael Osong-Michael marked this pull request as ready for review February 10, 2025 16:00
@Osong-Michael Osong-Michael added Review UAT Needed This PR requires User Acceptance Tests before merge and removed WIP labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review [Test Env] phobos UAT Needed This PR requires User Acceptance Tests before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants