Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commit with --no-verify (fixes #75) #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: commit with --no-verify (fixes #75) #76

wants to merge 2 commits into from

Conversation

mightyiam
Copy link

No description provided.

@teriu
Copy link

teriu commented Feb 12, 2018

Can we get this one reviewed by chance? We're needing the same functionality.

@travi
Copy link
Contributor

travi commented Feb 12, 2018

Could this be a regression for anyone? The only reason I ever used a commit hook is for running npm test... Others could be doing other things?

i do use other hooks, but since i leverage husky, hooks are not installed on CI. seems more appropriate for a non-interactive environment, like CI.

@elenadimitrova
Copy link

We're having the same problem here with greenkeeper-lockfile-update failing because of pre-commit hooks not found https://circleci.com/gh/JoinColony/colonyNetwork/2540#build-parameters/containers/0

@elenadimitrova elenadimitrova mentioned this pull request Jul 17, 2018
Merged
@janl
Copy link
Contributor

janl commented Sep 13, 2018

Heya @mightyiam would you be up for rebasing this? Thanks!

@mightyiam
Copy link
Author

Sure. In 24 hours.

mightyiam
mightyiam commented Sep 13, 2018
View reviewed changes
Copy link
Author

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct but I gotta say, this is purely theoretical...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mightyiam @teriu @travi @elenadimitrova @janl