Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ports argument for overrides and notes #755

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jun 8, 2022

What:

change port to str in overrides and notes:

port: Port to which the override applies, needs to be a string
in the form {number}/{protocol}

Why:

gvmd requires this

How:

Checklist:

@y0urself y0urself requested a review from a team as a code owner June 8, 2022 11:54
@y0urself y0urself enabled auto-merge (squash) June 8, 2022 11:54
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #755 (df12f46) into main (73e0400) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   98.68%   98.69%           
=======================================
  Files          56       56           
  Lines        4033     4057   +24     
  Branches     1046     1055    +9     
=======================================
+ Hits         3980     4004   +24     
  Misses         39       39           
  Partials       14       14           
Impacted Files Coverage Δ
gvm/protocols/gmpv208/entities/notes.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/overrides.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv214/entities/notes.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv214/entities/overrides.py 100.00% <100.00%> (ø)
gvm/utils.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@y0urself y0urself added the make release To trigger GitHub release action. label Jun 8, 2022
@y0urself y0urself merged commit 8c9057b into main Jun 9, 2022
@y0urself y0urself deleted the y0urself/fix-port branch June 9, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants