Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach help, system repots [FINAL] #473

Merged
merged 13 commits into from
May 21, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 20, 2021

What:

  • Improved and changed help(): Introduced HelpFormat Enum, changed format parameter to help_format using HelpFormat, changed help_type to brief and bool, as it only has two options (default and brief). #473
  • Changed filter to filter_string in getter functions. #470 #471 #473
  • Splitted up the GmpMonolith class:
    • Detached the SystemReports API calls from the GMP class into a new SystemReportsMixin. #473
    • Detached the Help API calls from the GMP class into a new HelpMixin. #473

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #473 (8d9cfcf) into master (b1214cd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files          54       54              
  Lines        3822     3840      +18     
  Branches      926      927       +1     
==========================================
+ Hits         3735     3753      +18     
  Misses         73       73              
  Partials       14       14              
Impacted Files Coverage Δ
gvm/protocols/gmpv208/entities/audits.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/entities.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/port_lists.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/severity.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/targets.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/tasks.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/tls_certificates.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/users.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/system/feed.py 100.00% <ø> (ø)
gvm/protocols/gmpv214/entities/notes.py 100.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1214cd...8d9cfcf. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review May 21, 2021 07:54
@y0urself y0urself requested a review from a team as a code owner May 21, 2021 07:54
@bjoernricks bjoernricks enabled auto-merge May 21, 2021 09:27
@bjoernricks bjoernricks merged commit aea2942 into greenbone:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants