-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor python-gvm API] Step 2: Detach help, system repots [FINAL] #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format -> help_format (HelpFormat), help_type -> brief (now Boolean: True: brief, False/None: default)
… but formats etc), added tests for new HelpFormat
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 54 54
Lines 3822 3840 +18
Branches 926 927 +1
==========================================
+ Hits 3735 3753 +18
Misses 73 73
Partials 14 14
Continue to review full report at Codecov.
|
…_config_preference(s).
bjoernricks
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
help()
: IntroducedHelpFormat
Enum, changedformat
parameter tohelp_format
usingHelpFormat
, changedhelp_type
tobrief
and bool, as it only has two options (default and brief). #473filter
tofilter_string
in getter functions. #470 #471 #473SystemReportsMixin
. #473HelpMixin
. #473Why:
How:
Checklist: