Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Credentials and Scanners #466

Merged
merged 9 commits into from
May 19, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 17, 2021

What:

  • Detached Credentials and Scanners into seperate Mixins

Why:

  • Improve python-gvm structure

How:

  • Split up large files and classes
  • find and delete bugs

Checklist:

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b519bb0). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #466   +/-   ##
=========================================
  Coverage          ?   97.59%           
=========================================
  Files             ?       38           
  Lines             ?     3783           
  Branches          ?        0           
=========================================
  Hits              ?     3692           
  Misses            ?       91           
  Partials          ?        0           
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 97.91% <ø> (ø)
gvm/protocols/gmpv208/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv214/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/credentials.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/scanners.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv214/entities/scanners.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b519bb0...16a52a4. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review May 19, 2021 07:36
@y0urself y0urself requested a review from a team as a code owner May 19, 2021 07:36
@y0urself y0urself enabled auto-merge May 19, 2021 07:36
@y0urself y0urself merged commit 486e1a3 into greenbone:master May 19, 2021
@y0urself y0urself deleted the detach-credentials-scanner branch October 9, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants