Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Audits #464

Merged
merged 9 commits into from
May 18, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 17, 2021

What:

  • Detach Audits into new AuditsMixin
  • Remove deprecated support of str for alert_ids

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #464 (cf5836d) into master (802093b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   97.28%   97.32%   +0.04%     
==========================================
  Files          32       33       +1     
  Lines        3571     3629      +58     
==========================================
+ Hits         3474     3532      +58     
  Misses         97       97              
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 98.62% <ø> (-0.12%) ⬇️
gvm/protocols/gmpv208/entities/audits.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/tasks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802093b...cf5836d. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review May 18, 2021 10:20
@y0urself y0urself requested a review from a team as a code owner May 18, 2021 10:20
@y0urself y0urself enabled auto-merge May 18, 2021 10:27
@y0urself y0urself merged commit 1e243f9 into greenbone:master May 18, 2021
@y0urself y0urself deleted the detach-audits branch May 18, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants