Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Tasks #443

Merged
merged 12 commits into from
Apr 30, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Apr 29, 2021

What:

  • Move Task Call into new TaskMixin
  • remove deprecated support of single alert_ids (str)

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #443 (18f35ab) into master (fd7c850) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   96.90%   96.94%   +0.04%     
==========================================
  Files          15       16       +1     
  Lines        3485     3539      +54     
==========================================
+ Hits         3377     3431      +54     
  Misses        108      108              
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 98.60% <ø> (-0.07%) ⬇️
gvm/protocols/gmpv208/entities/tasks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7c850...18f35ab. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review April 30, 2021 09:36
@y0urself y0urself requested a review from a team as a code owner April 30, 2021 09:36
@y0urself y0urself enabled auto-merge April 30, 2021 09:47
@y0urself y0urself merged commit b0370bb into greenbone:master Apr 30, 2021
@y0urself y0urself deleted the detach-tasks branch October 9, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants