Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drop GMP v7, v8 and v9 support] Step 1: Duplicate the code from old versions into the v20.08 API #436

Merged
merged 9 commits into from
Apr 27, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Apr 27, 2021

What:

  • Duplicating Types and API Calls from the versions 7, 8 and 9 into GMP 20.08
  • Duplicate Tests of deprecated versions into GMP 20.08 tests

Why:

  • Part One of Code Improvement of the python-gvm API

How:

Checklist:

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #436 (8efd04f) into master (0d53117) will increase coverage by 0.08%.
The diff coverage is 98.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   97.71%   97.79%   +0.08%     
==========================================
  Files          21       21              
  Lines        4683     7180    +2497     
==========================================
+ Hits         4576     7022    +2446     
- Misses        107      158      +51     
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 97.97% <ø> (-2.03%) ⬇️
gvm/protocols/gmpv208/types.py 98.81% <98.43%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d53117...8efd04f. Read the comment docs.

@y0urself y0urself changed the title Drop GMP v7, v8 and v9 support. [Drop GMP v7, v8 and v9 support] Step 1: Duplicate the code from old versions into the v20.08 API Apr 27, 2021
@y0urself y0urself marked this pull request as ready for review April 27, 2021 11:49
@y0urself y0urself requested a review from a team as a code owner April 27, 2021 11:49
@y0urself y0urself enabled auto-merge April 27, 2021 11:55
@y0urself y0urself merged commit c5499f2 into greenbone:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants