Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override FeedType and get_feed for 20.08 #434

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Override FeedType and get_feed for 20.08 #434

merged 6 commits into from
Apr 26, 2021

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 26, 2021

What:

With 20.08 we introduced the GVMD_DATA feed. This feed type was missing
in python-gvm.

Why:

We need the GVMD_DATA feed in hyperion.

How:

Checklist:

bjoernricks and others added 2 commits April 26, 2021 09:56
With 20.08 we introduced the GVMD_DATA feed. This feed type was missing
in python-gvm.
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #434 (f15eed4) into master (75746a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   97.70%   97.71%           
=======================================
  Files          21       21           
  Lines        4663     4683   +20     
=======================================
+ Hits         4556     4576   +20     
  Misses        107      107           
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75746a7...f15eed4. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review April 26, 2021 13:49
@y0urself y0urself requested a review from a team as a code owner April 26, 2021 13:49
y0urself
y0urself previously approved these changes Apr 26, 2021
y0urself
y0urself previously approved these changes Apr 26, 2021
@y0urself y0urself enabled auto-merge April 26, 2021 13:53
@y0urself y0urself merged commit 59849f2 into greenbone:master Apr 26, 2021
@bjoernricks bjoernricks deleted the feed-type-gvmd-data branch April 26, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants