Improve modify_user function #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 97.49% 97.51% +0.02%
==========================================
Files 20 20
Lines 4264 4311 +47
==========================================
+ Hits 4157 4204 +47
Misses 107 107
Continue to review full report at Codecov.
|
|
As mentioned before: I think this should be in an earlier version of gmp ...?! |
ArnoStiefvater
force-pushed
the
modify-user
branch
from
be11b79 to
4879a8b
Compare
But this change completely breaks the API. For example it is not possible to identifying a user by name anymore. Its not only adding stuff. I can modify the 208 function to include the comment, user_auth and group_ids params, but the name change breaks the API. |
Modify user now only takes an ID for identifying the user which is to be modified. The name parameter is now the new name and not an identifier anymore. The comment, auth_source and group_ids parameters got added. Now its possible to change those fields too. auth_source has to be used explicitly if not the default Source allowed for authentication for the user is to be used.
Add parameters comment, auth_source and group_ids. Make documentation about hosts_allow and ifaces_allow clearer.
ArnoStiefvater
force-pushed
the
modify-user
branch
from
4879a8b to
91af092
Compare
ArnoStiefvater
force-pushed
the
modify-user
branch
from
e7640c2 to
f930e4d
Compare
ArnoStiefvater
force-pushed
the
modify-user
branch
from
f930e4d to
7ff2176
Compare
|
you may add a test for the new Enum |
What:
The
comment,auth_sourceandgroup_idsparameters got added for gmpv7. Now its possible to change those fields too.auth_sourcehas to be used explicitly if not the default source allowed for authentication for the user is to be used.modify_usernow only takes an ID for identifying the user which is to be modified for gmpv214.The
nameparameter replaces the oldnew_nameparameter for gmpv214 and is not used for identifying a user anymore.Why:
To be able to set the appropriate fields.
How:
Added tests.
Checklist: