-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get reports with details by default #333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
- Coverage 97.47% 97.47% -0.01%
==========================================
Files 20 20
Lines 4235 4234 -1
==========================================
- Hits 4128 4127 -1
Misses 107 107
Continue to review full report at Codecov.
|
As your comment already suggests setting details to True by default should be the better solution. The comment should be updated to mention the new default then too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
details should be true instead of logging an info message. Setting sane defaults seems to be better to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just changing the method declaration to details: Optional[bool] = True
?
What:
In
get_report
isdetails
parameter isTrue
on default now ...Why:
It is frequently asked, why the report does not contain any information.
How:
Checklist: