Modify audit and policy #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 20 20
Lines 4221 4235 +14
=======================================
+ Hits 4114 4128 +14
Misses 107 107
Continue to review full report at Codecov.
|
nichtsfrei
approved these changes
Nov 12, 2020
bjoernricks
requested changes
Nov 12, 2020
| @@ -0,0 +1,222 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright (C) 2018 Greenbone Networks GmbH | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2018 Greenbone Networks GmbH | |
| # Copyright (C) 2020 Greenbone Networks GmbH |
|
|
||
| from gvm.errors import RequiredArgument, InvalidArgument, InvalidArgumentType | ||
|
|
||
| from gvm.protocols.gmpv7 import HostsOrdering |
There was a problem hiding this comment.
Suggested change
| from gvm.protocols.gmpv7 import HostsOrdering | |
| from gvm.protocols.gmpv9 import HostsOrdering |
| @@ -0,0 +1,60 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright (C) 2018 Greenbone Networks GmbH | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2018 Greenbone Networks GmbH | |
| # Copyright (C) 2020 Greenbone Networks GmbH |
| @@ -0,0 +1,189 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright (C) 2018 Greenbone Networks GmbH | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2018 Greenbone Networks GmbH | |
| # Copyright (C) 2020 Greenbone Networks GmbH |
| @@ -0,0 +1,113 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright (C) 2018 Greenbone Networks GmbH | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2018 Greenbone Networks GmbH | |
| # Copyright (C) 2020 Greenbone Networks GmbH |
| '</modify_task>' | ||
| ) | ||
|
|
||
| def test_modify_task_invalid_schedule_periods(self): |
There was a problem hiding this comment.
Suggested change
| def test_modify_task_invalid_schedule_periods(self): | |
| def test_modify_audit_invalid_schedule_periods(self): |
| with self.assertRaises(InvalidArgument): | ||
| self.gmp.modify_audit(audit_id='t1', schedule_periods=-1) | ||
|
|
||
| def test_modify_task_with_observers(self): |
There was a problem hiding this comment.
Suggested change
| def test_modify_task_with_observers(self): | |
| def test_modify_audit_with_observers(self): |
| '</modify_task>' | ||
| ) | ||
|
|
||
| def test_modify_task_invalid_observers(self): |
There was a problem hiding this comment.
Suggested change
| def test_modify_task_invalid_observers(self): | |
| def test_modify_audit_invalid_observers(self): |
| with self.assertRaises(InvalidArgumentType): | ||
| self.gmp.modify_audit(audit_id='t1', observers='foo') | ||
|
|
||
| def test_modify_task_with_preferences(self): |
There was a problem hiding this comment.
Suggested change
| def test_modify_task_with_preferences(self): | |
| def test_modify_audit_with_preferences(self): |
| '</modify_task>' | ||
| ) | ||
|
|
||
| def test_modify_task_invalid_preferences(self): |
There was a problem hiding this comment.
Suggested change
| def test_modify_task_invalid_preferences(self): | |
| def test_modify_audit_invalid_preferences(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added modifiers for Audits and Policies:
modify_auditsmodify_policy_set_nvt_preferencemodify_policy_set_namemodify_policy_set_commentmodify_policy_set_scanner_preferencemodify_policy_set_nvt_selectionmodify_policy_set_family_selectionWhy:
These API calls are missing.
How:
Using the
modify_taskandmodify_config_Checklist: