This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Move OSPDError and improve vts filter. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 66.77% 66.97% +0.19%
==========================================
Files 6 8 +2
Lines 1496 1511 +15
==========================================
+ Hits 999 1012 +13
- Misses 497 499 +2
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Mar 22, 2019
ospd/error.py
Outdated
| client """ | ||
|
|
||
| def __init__(self, message, command='osp', status=400): | ||
| super(OSPDError, self).__init__() |
There was a problem hiding this comment.
With python 3 you can just use
Suggested change
| super(OSPDError, self).__init__() | |
| super().__init__() |
bjoernricks
suggested changes
Mar 22, 2019
ospd/xml.py
Outdated
| def simple_response_str(command, status, status_text, content=""): | ||
| """ Creates an OSP response XML string. | ||
|
|
||
| @param: OSP Command to respond to. |
There was a problem hiding this comment.
Could you use the same docstring annotations as before?
Arguments:
name (type): ....
Move OSPDError class from ospd.ospd to its own module. Move simple_response_str() and get_result_xml() from ospd.ospd to its own module. This allows to import the modules from other files, avoiding an import loop. Update tests accordingly.
Improve docstrings too.
bjoernricks
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create module ospd.error and ospd.xml
Move OSPDError class from ospd.ospd to its own module.
Move simple_response_str() and get_result_xml() from ospd.ospd to its own module.
This allows to import the modules from other files, avoiding an import loop.
Update tests accordingly.
Improve the way in which the filter for vts is applied.
Add error handling to the filter passed to get_vts.