This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix scan progress. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* osdp/misc.py: Add 'target_progress' to scan_info dict to store the single target progress. Add set_target_progress() to store the scan progress of a target. Add get_target_progress(). * ospd/ospd.py: check_pending_target() handles the case in which the progress is not set from the wrapper for a single target, it will be automatically set if the target scan finished. Add calculate_progress(); it is the average of the target progress.
janowagner
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osdp/misc.py: Add 'target_progress' to scan_info dict to store the
single target progress. Add set_target_progress() to store the scan
progress of a target. Add get_target_progress().
ospd/ospd.py: check_pending_target() handles the case in which the
progress is not set from the wrapper for a single target, it will be
automatically set if the target scan finished.
Add calculate_progress(); it is the average of the target progress.
Add unit test for scan progress