This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Remove exclude hosts which do not belong to the target #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #377 +/- ##
==============================================
+ Coverage 73.94% 74.41% +0.47%
==============================================
Files 23 23
Lines 2610 2627 +17
==============================================
+ Hits 1930 1955 +25
+ Misses 680 672 -8
Continue to review full report at Codecov.
|
So, there is no need to calculate it each time from the target.
…ost_count() The simplifed excluded host count will be calculated just the first time. Then, the count is taken from the scan table.
…n. Actually, we need just an integer
jjnicola
added
backport-to-stable
jjnicola
changed the title
ArnoStiefvater
approved these changes
Mar 29, 2021
This was referenced Mar 29, 2021
jjnicola
added a commit
that referenced
this pull request
Mar 29, 2021
Remove exclude hosts which do not belong to the target (bp #377)
jjnicola
added a commit
that referenced
this pull request
Mar 29, 2021
Remove exclude hosts which do not belong to the target (bp #377)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove invalid exclude hosts which do not belongs to the target
Why:
Excluded hosts which don't belong to the target generate interrupted scans, because a wrong scan progress calculation
How:
With the patch, the scan should end as expected. Without the patch, it ends as interrupted.

Checklist: