This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix get_count_total(). Consider 0 value set by the server. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the possibility that the server finds 0 alive hosts, and it must not be overwritten with the value calculated by ospd from the target. None means that it was not set, 0 if set by the server and must not be overwritten.
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #366 +/- ##
===========================================
Coverage 73.94% 73.94%
===========================================
Files 23 23
Lines 2610 2610
===========================================
Hits 1930 1930
Misses 680 680
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Mar 9, 2021
bjoernricks
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix get_count_total(). Consider 0 value set by the server.
Why:
Consider the possibility that the server finds 0 alive hosts, and it must not
be overwritten with the value calculated by ospd from the target.
None means that it was not set, 0 if set by the server and must not be overwritten.
How:
Start a scan with a single host name in the target which can't be resolved. Without the patch it ends as interrupted. With the patch the scan finishes as expected.
Checklist: