Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add method to get a single host scan progress #363

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Mar 1, 2021

What:
Add method to get a single host scan progress

Why:
To check the scan progress of a single host.

How:

Checklist:

@jjnicola jjnicola requested a review from a team as a code owner March 1, 2021 14:28
@jjnicola jjnicola changed the base branch from master to ospd-20.08 March 1, 2021 14:29
@jjnicola jjnicola requested a review from bjoernricks as a code owner March 1, 2021 14:29
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #363 (7fac988) into ospd-20.08 (f39549b) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@              Coverage Diff               @@
##           ospd-20.08     #363      +/-   ##
==============================================
+ Coverage       73.93%   73.94%   +0.01%     
==============================================
  Files              23       23              
  Lines            2605     2610       +5     
==============================================
+ Hits             1926     1930       +4     
- Misses            679      680       +1     
Impacted Files Coverage Δ
ospd/scan.py 92.59% <ø> (-0.04%) ⬇️
ospd/ospd.py 71.74% <85.71%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39549b...7fac988. Read the comment docs.

ospd/ospd.py Show resolved Hide resolved
ospd/ospd.py Show resolved Hide resolved
The scan just ends with an interrupted scan. At this point in OSPD, we don't know what caused the interrupted scan. Before, the possible cause of an interrupted openvas scan were a duplicated host in target, unresolved host name, a race condition, and others. Many of the issues were already addressed, but as it depends on the scanner wrapper as well, IMHO this message must be generic. Probably I should set the log level to debug, since the user can't do so much in this cases.
@jjnicola jjnicola requested a review from bjoernricks March 9, 2021 09:02
@bjoernricks bjoernricks merged commit c7c195f into greenbone:ospd-20.08 Mar 9, 2021
@jjnicola jjnicola deleted the interrupted branch March 9, 2021 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants