This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Start with param #31
Merged
Start with param #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now each vt is a subelement of <vts>. It has an id attribute. Each vt accept multiple optional vt_param as subelements, with name and type as attribute and the value as text.
Update example for start_scan with vts parameters
janowagner
suggested changes
Jul 11, 2018
There was a problem hiding this comment.
I see three things to improve:
- The use of variable "id", see the CI error.
- Don't use ET.fromstring even in the tests module,
like I also mentioned in the other PR where secET
was introduced (partially). - "process something" is neither a helpful
command name and even more it is not helpful
as a function documentation. Please explain in
more detail in the doc string what "process it"
actually means.
Merged
|
I have done the improvements 1) and 3) . Regarding the point 2), as I explained in PR #30, I will do a new PR with the requested changes for the tests, to avoid merge conflicts. |
janowagner
approved these changes
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vts params to start_scan as a vt subelement.
Now each vt is a subelement of . It has an id attribute. Each vt accept multiple optional vt_param as subelements, with name and type as attribute and the value as text.
Update example for start_scan with vts parameters.
Add unittest to test VTs as elements and VT's parameters.