Set progress -2 for interrupted scans

[jjnicola]

No description provided.

[codecov]

Codecov Report

Merging #288 into master will decrease coverage by 0.08%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   75.12%   75.04%   -0.09%     
==========================================
  Files          22       22              
  Lines        2505     2517      +12     
==========================================
+ Hits         1882     1889       +7     
- Misses        623      628       +5     

Impacted Files	Coverage Δ
ospd/ospd.py	75.70% <93.33%> (-0.37%)	⬇️
ospd/scan.py	90.13% <100.00%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8672a75...04a8804. Read the comment docs.

[bjoernricks]

I am a bit confused when to use the value of the enum and when not to use it. It seems your code mixes that up too. For example:

     self.scan_collection.set_progress(
            scan_id, ScanProgress.INTERRUPTED.value
        )
        self.set_scan_status(scan_id, ScanStatus.FINISHED)

[jjnicola]

I am a bit confused when to use the value of the enum and when not to use it. It seems your code mixes that up too. For example:

     self.scan_collection.set_progress(
            scan_id, ScanProgress.INTERRUPTED.value
        )
        self.set_scan_status(scan_id, ScanStatus.FINISHED)

While ScanStatus is just an Enum class, ScanProgress is an IntEnum class. While the first one doesn't allow to use minor than < or greater than >, the second one yes. Then for the progress you need the value to send it to the client (e.g. 100), while the status is just the name (finished). During the comparisons, the values are not required, but it is necessary to store the progress value and not name in the scan table. When the get_scan is received, takes the progress in the right format from the scan table.