This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Use available memory instead of free memory #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 22 22
Lines 2480 2480
=======================================
Hits 1861 1861
Misses 619 619
Continue to review full report at Codecov.
|
When check for enough free memory before starting a scan, check for available memory now When the command line 'free -h' is called, the output shows two different values: available and free memory. Available is the one with more fluctuation and the one we should check instead of free, because it gives a more realistic value for checking if there is enough memory before starting a queued scan. More info can be found in the free command man page.
bjoernricks
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When check for enough free memory before starting a scan, check for available memory now
When the command line 'free -h' is called, the output shows two different values: available and free memory. Available is the one with more fluctuation and the one we should check instead of free, because it gives a more realistic value for checking if there is enough memory before starting a queued scan.
More info can be found in the free command man page.