Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add optional custom elements for VT information. #15

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

janowagner
Copy link
Member

This allows osdp scanners to add arbitrary custom elements to a VT
information.
Some elements such as "name" (some more in the future) are
predefined. But some scanners might need to manage addtional
and very individual elements.

ospd-based scanners can use add_vt() to add (optionally) also custom data.
Next, they can implement the function get_custom_vt_as_xml_str() to
create a xml string represenation of whatever the custom content is.

This allows osdp scanners to add arbitrary custom elements to a VT
information.
Some elements such as "name" (some more in the future) are
predefined. But some scanners might need to manage addtional
and very individual elements.

ospd-based scanners can use add_vt() to add (optionally) also custom data.
Next, they can implement the function get_custom_vt_as_xml_str() to
create a xml string represenation of whatever the custom content is.
@janowagner janowagner requested a review from a team June 11, 2018 20:41
@codecov
Copy link

codecov bot commented Jun 11, 2018

Codecov Report

Merging #15 into master will increase coverage by 0.2%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #15     +/-   ##
=========================================
+ Coverage   55.54%   55.74%   +0.2%     
=========================================
  Files           4        4             
  Lines        1037     1044      +7     
=========================================
+ Hits          576      582      +6     
- Misses        461      462      +1
Impacted Files Coverage Δ
ospd/ospd.py 61.79% <83.33%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e150c1b...d2e0739. Read the comment docs.

@jjnicola jjnicola merged commit 3a90a9c into greenbone:master Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants