This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Handle write error if the client disconnects abruptly #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 68.75% 68.59% -0.16%
==========================================
Files 12 12
Lines 1741 1745 +4
==========================================
Hits 1197 1197
- Misses 544 548 +4
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Sep 19, 2019
ospd/server.py
Outdated
| b_sent = self.socket.send(data[b_start:b_end]) | ||
| except BrokenPipeError: | ||
| logger.error( | ||
| "Client abruptly closes the connection" |
There was a problem hiding this comment.
Suggested change
| "Client abruptly closes the connection" | |
| "Client abruptly closed the connection" |
|
Can confirm, no longer dies when the client disconnects. |
jjnicola
force-pushed
the
handle-write-error
branch
from
6c2a6cd to
317852a
Compare
bjoernricks
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.