Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom date formatter to be used by the nvt filter. #57

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

jjnicola
Copy link
Member

Each wrapper has different formats for datetime values. This method
formats the datetime valued to be comapared with a standar format.

The method overwrites the original in the parent class.

Each wrapper has different formats for datetime values. This function
formats the datetime valued to be comapared with a standar format.
@jjnicola jjnicola requested a review from bjoernricks March 20, 2019 14:46
@jjnicola
Copy link
Member Author

Depends on greenbone/ospd#94

@jjnicola jjnicola marked this pull request as ready for review March 21, 2019 11:10
@jjnicola jjnicola force-pushed the vt-custom-filters branch from 020dd45 to e7525b2 Compare March 21, 2019 13:43
@@ -210,7 +226,8 @@ def __init__(self, certfile, keyfile, cafile):
""" Initializes the ospd-openvas daemon's internal data. """

super(OSPDopenvas, self).__init__(certfile=certfile, keyfile=keyfile,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: Could be simplified with python 3

Suggested change
super(OSPDopenvas, self).__init__(certfile=certfile, keyfile=keyfile,
super().__init__(certfile=certfile, keyfile=keyfile,

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #57 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #57      +/-   ##
=========================================
+ Coverage   71.61%   71.9%   +0.29%     
=========================================
  Files           4       4              
  Lines         775     783       +8     
=========================================
+ Hits          555     563       +8     
  Misses        220     220
Impacted Files Coverage Δ
ospd_openvas/wrapper.py 57.64% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac805d8...e7525b2. Read the comment docs.

@jjnicola jjnicola merged commit a1f025a into greenbone:master Mar 22, 2019
@jjnicola jjnicola deleted the vt-custom-filters branch March 22, 2019 09:08
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants