Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 21.04.0 #402

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Conversation

jjnicola
Copy link
Member

What:
Prepare for release 21.04.0

Why:

How:

Checklist:

@jjnicola jjnicola requested a review from a team as a code owner April 15, 2021 10:58
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #402 (913c7f7) into ospd-openvas-21.04 (440d69f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ospd-openvas-21.04     #402      +/-   ##
======================================================
- Coverage               84.23%   84.17%   -0.06%     
======================================================
  Files                       9        9              
  Lines                    1535     1536       +1     
======================================================
  Hits                     1293     1293              
- Misses                    242      243       +1     
Impacted Files Coverage Δ
ospd_openvas/daemon.py 67.53% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee7b7a...913c7f7. Read the comment docs.

@jjnicola jjnicola marked this pull request as draft April 15, 2021 14:55
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some small things that should be fixed here.

CHANGELOG.md Outdated
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [21.4] (unreleased)
## [21.04.0] (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we want to remove the padding zeroes in the version numbers, especially for Python projects?
Also, you forgot to add the date here.

CHANGELOG.md Outdated

## [20.8]
## [20.08.2] (unreleases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read "unreleased"

Suggested change
## [20.08.2] (unreleases)
## [20.08.2] (unreleased)

@jjnicola jjnicola force-pushed the release branch 2 times, most recently from 635914e to 2a3c41a Compare April 16, 2021 05:57
@jjnicola jjnicola marked this pull request as ready for review April 16, 2021 06:00
@jjnicola jjnicola requested a review from timopollmeier April 16, 2021 06:00
@jjnicola jjnicola dismissed timopollmeier’s stale review April 16, 2021 06:28

Requested changes already fix and PR approved by other dev

@jjnicola jjnicola merged commit 823f191 into greenbone:ospd-openvas-21.04 Apr 16, 2021
@jjnicola jjnicola deleted the release branch April 16, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants