Project maintenance #574
Merged
Project maintenance #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Python 3.12.
Remove the poetry.toml config file to let the users decide where poetry will create the virtual environment. It may desirable to not create the venv within the project directory.
The dev-dependencies got deprecated and replaced by generic groups with poetry >= 1.2.0.
It is required to calculate the coverage and was missing.
Put the coverage config into pyproject.toml.
Use the default changelog config and drop the generated changelog fo the 22.4.0 release. It's always possible to generate this file manually via `pontos-changelog`.
Python >= 3.9 is required since a while.
Our forum is on forum.greenbone.net nowadays.
Remove trailing newlines and auto format markdown.
Using poetry is only necessary for doing development. Point users to the INSTALL.md directly.
y0urself
reviewed
Jan 26, 2024
y0urself
previously approved these changes
Jan 26, 2024
ruff is just sooooooo much faster.
There is no need to use forking with systemd. We already changed all other services to run in "foreground".
Kali used this example for their config and the log file should be in /var/log/gvm beside all other logs from our software stack. Additionally /var/run is just a symlink to /run.
bjoernricks
force-pushed
the
project-maintenance
branch
from
ddd97e9 to
0b0408b
Compare
y0urself
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the project
Why
Do some maintenance