Add: Support authenticated connection to MQTT broker #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
If notus-scanner options --mqtt-broker-user and `--mqtt-broker-password are given (or configured in the notus-scanner.toml configuration file), the connection will be authenticated. For this to work, MQTT broker must be configured with valid user and pass. This is disable per default. SC-917
|
Hi @jjnicola, could you add tests to https://github.com/greenbone/notus-scanner/blob/main/tests/cli/test_cli_parser.py for the new settings also? |
nichtsfrei
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support authenticated connection to MQTT broker
If notus-scanner options --mqtt-broker-user and `--mqtt-broker-password are given (or configured in the notus-scanner.toml configuration file), the connection will be authenticated. For this to work, MQTT broker must be configured with valid user and pass. This is disable per default.
SC-917
Why
Improvement
References
Checklist