Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import predefined configs from feed at startup #931

Merged
merged 22 commits into from
Jan 13, 2020
Merged

Import predefined configs from feed at startup #931

merged 22 commits into from
Jan 13, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jan 9, 2020 •
edited
Loading

This startup check adds any new configs from the feed, but does not update existing configs.

Checklist:

@mattmundell
Copy link
Contributor Author

Needs #923 first.

@mattmundell
Copy link
Contributor Author

mattmundell commented Jan 10, 2020 •
edited
Loading

This is ready for review after #923.

There are still some additions required but I think they should wait because this PR is already big:

@mattmundell mattmundell marked this pull request as ready for review January 10, 2020 15:08
@jjnicola jjnicola self-requested a review January 13, 2020 13:00
@jjnicola jjnicola merged commit 79549af into greenbone:master Jan 13, 2020
@mattmundell mattmundell deleted the startup-import-configs branch January 13, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @jjnicola