Add option --optimize migrate-relay-sensors (9.0) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If relays are active, this can be used to make sure all sensor type scanners have a matching relay, i.e. OSP sensors have an OSP relay and GMP scanners have an GMP relay. GMP scanners are migrated to OSP sensors if an OSP relay is available.
Documentation comments for the functions get_relay_info_entity and relay_supports_scanner_type was still missing.
mattmundell
requested changes
Oct 24, 2019
Co-Authored-By: Matt Mundell <[email protected]>
There should be no space before the increment operator.
The check in relay_supports_scanner_type if entity_text is non-NULL and an "else" in get_relay_info_entity were not needed.
mattmundell
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If relays are active, this can be used to make sure all sensor type
scanners have a matching relay, i.e. OSP sensors have an OSP relay
and GMP scanners have an GMP relay.
GMP scanners are migrated to OSP sensors if an OSP relay is available.
Checklist: