Incoming VT timestamps are seconds since epoch #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
resolve_tags
branch
from
9b40a1e to
b1ae285
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
janowagner
force-pushed
the
resolve_tags
branch
from
8311077 to
d597c0b
Compare
With greenbone/gvm-libs#265 the OSP timestamps are seconds since epoch and not anymore arbitrarily formatted timestamps. This makes it easier for gvmd because no special parsing of timestamps is not needed anymore.
janowagner
force-pushed
the
resolve_tags
branch
from
d597c0b to
589a335
Compare
This delivers long on the hand and is safer on the other hand compared to "atol" since overflow/underflow are handled.
timopollmeier
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With greenbone/gvm-libs#265 the OSP timestamps
are seconds since epoch and not anymore arbitrarily formatted
timestamps.
This makes it easier for gvmd because no special parsing of timestamps
is not needed anymore.
Checklist: