Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORPHAN calculation in GET_TICKETS #684

Merged
merged 4 commits into from
Aug 12, 2019
Merged

Fix ORPHAN calculation in GET_TICKETS #684

merged 4 commits into from
Aug 12, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Aug 11, 2019 •
edited
Loading

Checklist:

@mattmundell
Get result ID from ticket_results instead of from results
eb08e81 
The report may have been deleted, in which case the ID won't be
available in results.
@mattmundell
Use accessor to get orphan state
0e133bc 
The presence of ticket_results is not a good indicator because the
ticket_results are kept when the task is deleted.
@mattmundell
Add changelog
518ed54
@mattmundell mattmundell changed the title Ticket orphans Fix ORPHAN calculation in GET_TICKETS Aug 11, 2019
@mattmundell mattmundell marked this pull request as ready for review August 11, 2019 21:12
timopollmeier
timopollmeier reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look okay so far but shouldn't the tickets also count as orphaned if the report has been deleted?

@mattmundell
Copy link
Contributor Author

The changes look okay so far but shouldn't the tickets also count as orphaned if the report has been deleted?

Yes good point, but I think that should be a new PR.

@timopollmeier timopollmeier merged commit de148ff into greenbone:master Aug 12, 2019
@mattmundell mattmundell deleted the ticket-orphans branch August 12, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier