Check and create default permissions individually (master) #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gvmd startup will now check and create the permissions for the built-in roles and resources individually instead of just looking for any permissions for each role.
mattmundell
requested changes
Aug 8, 2019
The parameter for checking permissions individually has been removed because it was always TRUE. Indentation will be fixed in another patch for diff readability.
In add_permissions_on_globals and check_db_permissions remove extra indentation left after removing conditions.
…md into default-permissions-fix
mattmundell
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gvmd startup will now check and create the permissions for the
built-in roles and resources individually instead of just looking for
any permissions for each role.
Checklist: