Add usage_type for configs and tasks #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configs are now marked as either a "scan" config or a "policy" while tasks are marked either "scan" tasks or "audits".
mattmundell
approved these changes
Jun 21, 2019
mattmundell
requested changes
Jun 21, 2019
The variable isn't just escaping the quotes, so quoted_usage_type wasn't the most appropriate name. It is also changed to const char* because allocating and freeing memory is unnecessary for fixed values.
|
The documentation has been fixed now (395696d). |
mattmundell
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configs are now marked as either a "scan" config or a "policy" while tasks are marked either "scan" tasks or "audits".
While the tasks and configs currently still behave the same, normal vulnerability assessments can now be handled separately from compliance audits.