Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ignore_pagination in delta reports (8.0) #597

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Apply ignore_pagination in delta reports (8.0) #597

merged 1 commit into from
Jun 19, 2019

Conversation

timopollmeier
Copy link
Member

Delta reports still used the filter values for first_result and
max_results (instead of 1 and -1) if ignore_pagination was enabled.

@timopollmeier
Apply ignore_pagination in delta reports
b450ed9 
Delta reports still used the filter values for first_result and
max_results (instead of 1 and -1) if ignore_pagination was enabled.
@timopollmeier timopollmeier requested a review from a team June 18, 2019 12:33
swaterkamp
swaterkamp approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this patch on my gvmd-8.0 branch and it solves the problem. I can now flip pages of results in delta reports.

@swaterkamp swaterkamp merged commit 508dab3 into greenbone:gvmd-8.0 Jun 19, 2019
@timopollmeier timopollmeier deleted the delta-ignore_pagination-8.0 branch August 8, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @swaterkamp