Improve report counts performance #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When counting unfiltered report result severities, the WHERE access check queries for the results are not used, so they can be omitted to improve performance.
The init_result_get_iterator_severity function now uses WITH clauses for the permissions in the valid_overrides.
It should only be attempted to free the WITH clause if the output parameter for it is not NULL.
nichtsfrei
approved these changes
Mar 10, 2021
timopollmeier
added
backport-to-oldstable
|
@Mergifyio refresh |
|
Command
|
This was referenced Mar 10, 2021
timopollmeier
added a commit
that referenced
this pull request
Mar 15, 2021
The WITH clause code in init_result_get_iterator_severity has been moved into an if block and the scope of some variables has changed accordingly.
timopollmeier
added a commit
that referenced
this pull request
Mar 15, 2021
The WITH clause code in init_result_get_iterator_severity has been moved into an if block and the scope of some variables has changed accordingly.
nichtsfrei
added a commit
that referenced
this pull request
Mar 17, 2021
Improve report counts performance (bp #1438)
timopollmeier
added a commit
that referenced
this pull request
Mar 17, 2021
Improve report counts performance (bp #1438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This improves the performance of creating the report counts cache by removing unused permission check WITH clauses from the SQL and instead using WITH clauses for the overrides.
Why:
Updating the report counts cache is slow, especially when updating overrides.
How did you test it:
By running the
modify_overrideGMP command and viewing various pages in GSA like results and reports.Checklist: