Drop notes threat #1324
Merged
Drop notes threat #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is either "Alarm" or empty when it is a log message. So it adds no information because the element severity also offers the information whether it is Alarm (severity>0) or log (severity=0).
janowagner
force-pushed
the
drop_notes_threat
branch
from
b2cee88 to
f3b1b4d
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove element "threat" of element "note" in GMP.
Why:
It isn't used anywhere on the UI and it is redundant because there is also
element "severity".
This is also removing the very last occurrances of "Security Hole", "Security Warning"
and "Security Note", a long deprecated message type.
How:
The element wasn't used anyway.
The XML output was compared before and after the patch to proof a clean
removal of the element.
Checklist: