Check db version before creating SQL functions #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Do the db version check before creating the SQL functions.
Why:
"CREATE OR REPLACE FUNCTION" fails if an argument name changes and the body of the function changes. In this case the migrator needs to be run before the "CREATE OR REPLACE FUNCTION", so we have to check the versions first.
How:
database is wrong version
log, and not aPQexec failed: ERROR: cannot change name of input parameter “lvl”
log.Checklist: