Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For radio prefs in GMP exclude value and include default #1296

Merged
merged 4 commits into from
Sep 14, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Sep 14, 2020

What:

For radio preferences in GMP, as returned by GET_NVTS:

  • include the option that is in DEFAULT_VALUE in the possible ALTs
  • never include an ALT for the option that is in VALUE.

Related recent PR: #1278

Why:

This is the expected behaviour.

How:

Create Base config
Edit "Timing policy :" of "Nmap (NASL wrapper)" to "Insane", "Polite" or "Aggressive".
Open the edit dialog for "Nmap (NASL wrapper)"
The list for "Timing policy :" should include "Insane" and "Aggressive" (and "Polite" but it always did).

Checklist:

@mattmundell mattmundell changed the title Pref radio include value For radio prefs in GMP exclude value and include default Sep 14, 2020
@mattmundell mattmundell marked this pull request as ready for review September 14, 2020 12:25
@jjnicola jjnicola merged commit aa30945 into gvmd-20.08 Sep 14, 2020
@jjnicola jjnicola deleted the pref-radio-include-value branch September 14, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants